Add Tree Group Color Shuffling #6586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to group_colors * 'group_colors' of github.com:scalableminds/webknossos: added typescript definitions for react-sortable-tree
…up_colors * 'master' of github.com:scalableminds/webknossos: suppress error toasts in isDatasetAccessibleBySwitching API call (#6580)
hotzenklotz
commented
Oct 24, 2022
| > | ||
| <i className="fas fa-adjust" /> Shuffle Tree Group Colors | ||
| </Menu.Item> | ||
| {id !== MISSING_GROUP_ID ? ( |
There was a problem hiding this comment.
The group to tree accessors/helpers do not work with the root group. Hence, we can not offer this option on the root group.
There was a problem hiding this comment.
For the sake of completeness/consistency, I'd add an extra method for this case (similar to the shuffle-all-trees case). I think, it should quite short. Something like:
function ... {
const setTreeColorActions = Object.keys(this.props.trees).map((treeId) => setTreeColorAction(treeId, color));
this.props.onBatchActions(setTreeColorActions, "SET_TREE_COLOR");
}There was a problem hiding this comment.
Good idea. I added such a method.
hotzenklotz
commented
Oct 24, 2022
| getNodeStyleClassForBackground = (id: number) => { | ||
| const isTreeSelected = this.props.selectedTrees.includes(id); | ||
|
|
||
| if (isTreeSelected) { | ||
| return "selected-tree-node"; | ||
| } | ||
|
|
||
| return null; | ||
| return undefined; |
There was a problem hiding this comment.
Change for type compatibility
philippotto
requested changes
Oct 25, 2022
frontend/javascripts/oxalis/view/right-border-tabs/tree_hierarchy_view.tsx
Outdated
Show resolved
Hide resolved
| > | ||
| <i className="fas fa-adjust" /> Shuffle Tree Group Colors | ||
| </Menu.Item> | ||
| {id !== MISSING_GROUP_ID ? ( |
There was a problem hiding this comment.
For the sake of completeness/consistency, I'd add an extra method for this case (similar to the shuffle-all-trees case). I think, it should quite short. Something like:
function ... {
const setTreeColorActions = Object.keys(this.props.trees).map((treeId) => setTreeColorAction(treeId, color));
this.props.onBatchActions(setTreeColorActions, "SET_TREE_COLOR");
}
philippotto
reviewed
Oct 25, 2022
frontend/javascripts/oxalis/view/right-border-tabs/tree_hierarchy_view.tsx
Outdated
Show resolved
Hide resolved
philippotto
approved these changes
Oct 25, 2022
…chy_view.tsx Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds the functionality to set and shuffle the colors of a whole tree group. I also fixed/added some more TS type hints for that file.
URL of deployed dev instance (used for testing):
Steps to test:
lgn_c_22_demo_synapses.nml.zip
Issues:
(Please delete unneeded items, merge only when none are left open)