Context action to move tree to group

[dieknolle3333]

Steps to test:

• Go to any annotions view of a dataset and switch to the Skeleton tab
• With any tree active, right-click a group and make sure there is a context action called Move active tree here
• Repeat this step having selected multiple trees. Make sure the label of the context action is adjusted to "trees".
• Actually move a single and multiple trees to a group and see that it works.
• It is not yet possible to move a group to another group via context action. Thus the context action shouldnt appear if a group is active and you want to move it to another group.
• After having selected multiple trees, clear the selection. Right-click a group and make sure there is no context action called Move active [group|trees?] here without an active component.

Issue:

• fixes "Move selected trees/groups into this group" as context action #6973

---

• Updated changelog
• Removed dev-only changes like prints and application.conf edits
• Considered common edge cases

[philippotto]

Works great 🎉 Code looks also good, but I left a couple of smaller suggestions.

Also, I noticed that the context menu doesn't close automatically. This is also the case for other entries, but I think, we should change that. Can you add

this.handleTreeDropdownMenuVisibility(tree.treeId, false);

in the context menu item handlers where it makes sense so that the menu closes after the action? for shuffle-tree-colors, the menu shouldn't close automatically, so that users can shuffle repeatedly until they are satisfied with the new color.

[dieknolle3333]

Works great tada Code looks also good, but I left a couple of smaller suggestions.

Also, I noticed that the context menu doesn't close automatically. This is also the case for other entries, but I think, we should change that. Can you add

this.handleTreeDropdownMenuVisibility(tree.treeId, false);

in the context menu item handlers where it makes sense so that the menu closes after the action? for shuffle-tree-colors, the menu shouldn't close automatically, so that users can shuffle repeatedly until they are satisfied with the new color.

Thank you for the quick review!

Regarding the automatic closing of the context menu, are you referring only to group context actions or to tree context actions aswell? For group context actions, I understand that I need to close the dropdown in cases where it's useful.
For tree actions, the menu closes automatically if I delete the tree or hide/show other trees and remains open for all other actions afaict. Should this also be adjusted in any way?
[Edit:] I will add it for tree actions aswell and see what you say :)

[philippotto]

Regarding the automatic closing of the context menu, are you referring only to group context actions or to tree context actions aswell? For group context actions, I understand that I need to close the dropdown in cases where it's useful.
For tree actions, the menu closes automatically if I delete the tree or hide/show other trees and remains open for all other actions afaict. Should this also be adjusted in any way?
[Edit:] I will add it for tree actions aswell and see what you say :)

Yes, I think, your changes make sense 👍 The only thing is that this doesn't work well for "Change tree color", because that menu item opens a color picker and with your newest changes the color picker closes immediately after one has changed the color for the very first time. I added two code suggestion which revert that and then, the PR should be good to go :)

[philippotto]

Excellent 🎉 Feel free to merge 👍

[dieknolle3333]

I think I deleted my changelog entry when merging main into my branch, so I updated it again 😅