Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zarr string fill values #7017

Merged
merged 8 commits into from
May 2, 2023
Merged

Use zarr string fill values #7017

merged 8 commits into from
May 2, 2023

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Apr 25, 2023

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Remove one chunk
  • Request buckets with that chunk

Issues:

Not sure if converting infinity to max value is useful (and the other direction).


(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Needs datastore update after deployment

@frcroth frcroth self-assigned this Apr 25, 2023
@frcroth
Copy link
Member Author

frcroth commented Apr 25, 2023

image
image

@frcroth frcroth requested a review from fm3 April 25, 2023 14:49
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Thanks for going through the data types! I guess for i4 it should also be MinValue :)

frcroth and others added 2 commits April 28, 2023 11:36
…e/datareaders/ArrayDataType.scala

Co-authored-by: Florian M <fm3@users.noreply.github.com>
@frcroth frcroth requested a review from fm3 April 28, 2023 09:37
@frcroth frcroth merged commit 12cc8fa into master May 2, 2023
2 checks passed
@frcroth frcroth deleted the zarr-string-fill-values branch May 2, 2023 08:23
hotzenklotz added a commit that referenced this pull request May 17, 2023
…ty-list-drawings

* 'master' of github.com:scalableminds/webknossos: (25 commits)
  Fix issues with styling in dark mode on login page (#7052)
  Fix nightly by setting missing token (#7048)
  Release 23.05.1 (#7042)
  DRY types in update_actions.ts (#7036)
  Remove some spammy logging from backend (#7039)
  Use zarr string fill values (#7017)
  Fix voxel offset for Neuroglancer Precomputed datasets (#7019)
  Log when user is activated (#7027)
  Fix exception in applying UpdateTreeGroupVisibility skeleton action (#7037)
  Fix organization storage layouting (#7034)
  Update docker compose commands + dev install readme (#7002)
  Add segment groups (#6966)
  Add screenshot nightly test for wkorg (#7030)
  Workaround for WebGL crash for datasets with many segmentation layers (#6995)
  Fix download of public annotation, include access ctx in user cache key (#7025)
  Fix that changing a segment color could lead to a crash (#7000)
  Add more error chaining to annotation download (#7023)
  Guard against NaNs in shader (#7018)
  Store editable mappings in multiple fossildb columns+keys (#6903)
  Context action to move tree to group (#7005)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zarr data loading: double-check fill values
2 participants