Team edit modal #7043

dieknolle3333 · 2023-05-02T21:49:27Z

Steps to test:

Go to teams list
Click on Add/Remove Users
Wait for modal to load (demo only)
click into modal
remove and add users
make sure changes are updating the next time the dropdown is opening

Issues:

fixes Allow to add/remove users in teams view #7035

(Please delete unneeded items, merge only when none are left open)

Updated changelog
~~-[ ] Updated documentation if applicable~~
Removed dev-only changes like prints and application.conf edits
Considered common edge cases

frontend/javascripts/admin/team/edit_team_modal_view.tsx

philippotto · 2023-05-05T12:57:41Z

I didn't look at the code yet, but already tested the PR out :) Some thoughts:

while removing/adding a user, there's no loading indicator. you can throttle your internet connection in the browser debugging tools to check this. I'd suggest to put everything in the modal inside of a <Spin spinning={pendingRequestsCounter > 0}>...</...> container and then increase/decrease pendingRequestsCounter before/after an add/remove request.
admin users cannot be removed from a team which makes sense, but I'd add a tooltip to the "Admin" label to explain this :)

Other than that it already feels quite good 👍 If the dropdown wouldn't close when clicking the actual name (see my other comment), this would be the cherry on the top 🍒

This reverts commit fd32e29.

frontend/javascripts/admin/team/edit_team_modal_view.tsx

philippotto

excellent, it works really well 👍

only one last UI suggestion: please add a small "minus" icon button next to each user in the the users list (not in the dropdown) so that one can also use that button to remove a user from a team (without having to use the dropdown).

frontend/javascripts/admin/team/edit_team_modal_view.tsx

philippotto

excellent, it works really well 👍

only one last UI suggestion: please add a small "minus" icon button next to each user in the the users list (not in the dropdown) so that one can also use that button to remove a user from a team (without having to use the dropdown).

philippotto · 2023-05-09T07:43:14Z

frontend/javascripts/admin/team/team_list_view.tsx

+export function renderUsersForTeam(
+  team: APITeam,
+  allUsers: APIUser[] | null,
+  renderAdditionalContent = Function(),


The Function() part is quite unusual in JS. Usually, it would be used to create a function from a string. Also new Function() would be cleaner. To avoid Function(), I would suggest this:

Suggested change

renderAdditionalContent = Function(),

renderAdditionalContent = (_teamMember: APIUser, _team: APITeam) => {},

Alright! This is a good reminder to double check what I'm reading on blogs 😅

Why are you using the _syntax for _teamMember and _team?

Without the leading underscore signals the linter would complain about the unused function parameters. Adding an underscore to the name silents the linter :) The parameters are unused here, but we need them so that TS knows the type of the function.

Makes sense, thanks!

philippotto · 2023-05-09T07:45:17Z

great! I got one last code suggestion and the todo/test comments/code can be removed now :)

philippotto

Beautiful :)

…ty-list-drawings * 'master' of github.com:scalableminds/webknossos: (23 commits) fix scrolling in organization switcher in terms-of-services modal (#7083) Auto-Select via SAM (#7051) Build STL in chunks when exporting them (#7074) Improve performance for large (oversegmentation) meshes (#7077) Fix display of used storage in power plan (#7057) Fix user limits for invites (#7078) adds fileSize to voxelytics workflow list (#7071) Improve error logging for bucket requests (#7053) Fix zarr streaming datasource-properties.json generation for non-wkw/zarr datasets (#7065) Min length for layer names is one (#7064) Include voxelytics workflow name in tab title (#7070) Fix local to global layer index look up (#7066) Merge editable mappings (#7026) store correct artifacts for wkorg nightly (#7060) Team edit modal (#7043) Fix voxel offset in chunk name for unsharded neuroglancer precomputed datasets (#7062) Fix offset when loading non-aligned buckets for zarr/n5/precomputed (#7058) fixes wallTimes query for workflow reports (#7059) Handle Remote Dataset Edge Cases: compressed content-encoding, float voxel size (#7041) Release 23.05.2 (#7056) ...

…ove_wkconnect * 'master' of github.com:scalableminds/webknossos: (33 commits) Fix bug in fallback rendering when layer has missing mags (#7082) Fix duplicate on volumes with no fallback layer (#7085) fix scrolling in organization switcher in terms-of-services modal (#7083) Auto-Select via SAM (#7051) Build STL in chunks when exporting them (#7074) Improve performance for large (oversegmentation) meshes (#7077) Fix display of used storage in power plan (#7057) Fix user limits for invites (#7078) adds fileSize to voxelytics workflow list (#7071) Improve error logging for bucket requests (#7053) Fix zarr streaming datasource-properties.json generation for non-wkw/zarr datasets (#7065) Min length for layer names is one (#7064) Include voxelytics workflow name in tab title (#7070) Fix local to global layer index look up (#7066) Merge editable mappings (#7026) store correct artifacts for wkorg nightly (#7060) Team edit modal (#7043) Fix voxel offset in chunk name for unsharded neuroglancer precomputed datasets (#7062) Fix offset when loading non-aligned buckets for zarr/n5/precomputed (#7058) fixes wallTimes query for workflow reports (#7059) ...

dieknolle3333 added 11 commits April 25, 2023 09:27

places to look

9d36ebd

basic modal with autocomplete

dbccb1d

trying to fetch users

03ba443

basic search for users in modal

1aaa0a2

zwischenstand

420b4db

add methods, but doesnt work

4d1653e

fix error

196a688

fix error here too

5228e1f

merge temp changes

d690204

add and remove functionality

6aea6f4

spinner while loading

c724bb3

dieknolle3333 self-assigned this May 5, 2023

dieknolle3333 added 2 commits May 5, 2023 12:03

render list with team members

4fe83a0

Merge branch 'master' into team-edit-modal

b84b68a

dieknolle3333 commented May 5, 2023

View reviewed changes

frontend/javascripts/admin/team/edit_team_modal_view.tsx Outdated Show resolved Hide resolved

fix options typing

56f56d4

dieknolle3333 commented May 5, 2023

View reviewed changes

frontend/javascripts/admin/team/edit_team_modal_view.tsx Outdated Show resolved Hide resolved

dieknolle3333 commented May 5, 2023

View reviewed changes

frontend/javascripts/admin/team/edit_team_modal_view.tsx Outdated Show resolved Hide resolved

dieknolle3333 marked this pull request as ready for review May 5, 2023 12:24

dieknolle3333 requested a review from philippotto May 5, 2023 12:39

dieknolle3333 added 3 commits May 5, 2023 16:38

Select rather than AutoComplete

fd32e29

Revert "Select rather than AutoComplete"

30a3ab2

This reverts commit fd32e29.

fix closing of dropdown

4ec09a0

dieknolle3333 marked this pull request as draft May 7, 2023 16:20

add tooltip and spinner

3ca3d4a

dieknolle3333 commented May 8, 2023

View reviewed changes

frontend/javascripts/admin/team/edit_team_modal_view.tsx Outdated Show resolved Hide resolved

dieknolle3333 commented May 8, 2023

View reviewed changes

frontend/javascripts/admin/team/edit_team_modal_view.tsx Outdated Show resolved Hide resolved

dieknolle3333 added 2 commits May 8, 2023 13:46

add changelog

ba7062b

Merge branch 'master' into team-edit-modal

cadf8d1

dieknolle3333 marked this pull request as ready for review May 8, 2023 11:47

philippotto reviewed May 8, 2023

View reviewed changes

frontend/javascripts/admin/team/edit_team_modal_view.tsx Outdated Show resolved Hide resolved

philippotto reviewed May 8, 2023

View reviewed changes

dieknolle3333 added 3 commits May 8, 2023 16:44

merge master

e01c01b

isWating as bool

ab76edd

add minus for statis lsit

12abf84

philippotto reviewed May 9, 2023

View reviewed changes

dieknolle3333 added 2 commits May 9, 2023 11:04

address review

825fb34

Merge branch 'master' into team-edit-modal

31ee9ab

dieknolle3333 requested a review from philippotto May 9, 2023 09:18

Merge branch 'master' into team-edit-modal

fea9386

philippotto approved these changes May 9, 2023

View reviewed changes

dieknolle3333 merged commit 22914a1 into master May 9, 2023
2 checks passed

dieknolle3333 deleted the team-edit-modal branch May 9, 2023 09:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Team edit modal #7043

Team edit modal #7043

dieknolle3333 commented May 2, 2023 •

edited

philippotto commented May 5, 2023

philippotto left a comment

philippotto left a comment

philippotto May 9, 2023

dieknolle3333 May 9, 2023

dieknolle3333 May 9, 2023

philippotto May 9, 2023

dieknolle3333 May 9, 2023

philippotto commented May 9, 2023

philippotto left a comment

	renderAdditionalContent = Function(),
	renderAdditionalContent = (_teamMember: APIUser, _team: APITeam) => {},

Team edit modal #7043

Team edit modal #7043

Conversation

dieknolle3333 commented May 2, 2023 • edited

Steps to test:

Issues:

philippotto commented May 5, 2023

philippotto left a comment

Choose a reason for hiding this comment

philippotto left a comment

Choose a reason for hiding this comment

philippotto May 9, 2023

Choose a reason for hiding this comment

dieknolle3333 May 9, 2023

Choose a reason for hiding this comment

dieknolle3333 May 9, 2023

Choose a reason for hiding this comment

philippotto May 9, 2023

Choose a reason for hiding this comment

dieknolle3333 May 9, 2023

Choose a reason for hiding this comment

philippotto commented May 9, 2023

philippotto left a comment

Choose a reason for hiding this comment

dieknolle3333 commented May 2, 2023 •

edited