Fix bug in fallback rendering when layer has missing mags #7082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve due to missing mags
daniel-wer
approved these changes
May 17, 2023
hotzenklotz
added a commit
that referenced
this pull request
May 17, 2023
…ove_wkconnect * 'master' of github.com:scalableminds/webknossos: (33 commits) Fix bug in fallback rendering when layer has missing mags (#7082) Fix duplicate on volumes with no fallback layer (#7085) fix scrolling in organization switcher in terms-of-services modal (#7083) Auto-Select via SAM (#7051) Build STL in chunks when exporting them (#7074) Improve performance for large (oversegmentation) meshes (#7077) Fix display of used storage in power plan (#7057) Fix user limits for invites (#7078) adds fileSize to voxelytics workflow list (#7071) Improve error logging for bucket requests (#7053) Fix zarr streaming datasource-properties.json generation for non-wkw/zarr datasets (#7065) Min length for layer names is one (#7064) Include voxelytics workflow name in tab title (#7070) Fix local to global layer index look up (#7066) Merge editable mappings (#7026) store correct artifacts for wkorg nightly (#7060) Team edit modal (#7043) Fix voxel offset in chunk name for unsharded neuroglancer precomputed datasets (#7062) Fix offset when loading non-aligned buckets for zarr/n5/precomputed (#7058) fixes wallTimes query for workflow reports (#7059) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The computation of the representative mag (used for aligning the vertices with the buckets) effectively ignored layers for which the active mag doesn't exist. However, the fallback mags should be taken into account in that case.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)