Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bounding box by dragging with box tool #7118

Merged
merged 7 commits into from
Jun 7, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jun 2, 2023

URL of deployed dev instance (used for testing):

Steps to test:

  • activate tool
  • create a bounding box by dragging

Issues:

  • no issue

(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Updated documentation if applicable not necessary, since the tool is not explained in detail in the docs (as it's quite self-explanatory)

@philippotto philippotto changed the title [WIP] Create bounding box by dragging with box tool Create bounding box by dragging with box tool Jun 5, 2023
@philippotto philippotto marked this pull request as ready for review June 5, 2023 11:27
@philippotto philippotto self-assigned this Jun 5, 2023
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, works very well! 🥳

Only small issue I saw is that the cursor, when not hovering over any bounding box, still indicates a move action which is no longer accurate.

@philippotto
Copy link
Member Author

Done, please check again :)

Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cursor choice ✨

@bulldozer-boy bulldozer-boy bot merged commit 237ad6e into master Jun 7, 2023
2 checks passed
@bulldozer-boy bulldozer-boy bot deleted the create-bbox-by-drag branch June 7, 2023 15:33
hotzenklotz added a commit that referenced this pull request Jun 8, 2023
…esign-right-sidebar

* 'master' of github.com:scalableminds/webknossos:
  Create bounding box by dragging with box tool (#7118)
  Prevent 'negative' buckets from being created (#7124)
  Lazy load onnx and canvas2html module (#7121)
  Disable editing of super voxel skeletons in skeleton mode (#7086)
  add missing evolution to migration guide (#7126)
  Change sttp backend to HttpURLConnectionBackend (#7125)
  Implement Zarr v3 and sharding codec (#7079)
  Fix decompression of garbage data after valid gzip data causing decompression to fail (#7119)
  When scanning volume buckets, skip those with unparseable key (#7115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants