Change sttp backend to HttpURLConnectionBackend #7125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm3
approved these changes
Jun 6, 2023
Great find 👍 |
hotzenklotz
added a commit
that referenced
this pull request
Jun 8, 2023
…esign-right-sidebar * 'master' of github.com:scalableminds/webknossos: Create bounding box by dragging with box tool (#7118) Prevent 'negative' buckets from being created (#7124) Lazy load onnx and canvas2html module (#7121) Disable editing of super voxel skeletons in skeleton mode (#7086) add missing evolution to migration guide (#7126) Change sttp backend to HttpURLConnectionBackend (#7125) Implement Zarr v3 and sharding codec (#7079) Fix decompression of garbage data after valid gzip data causing decompression to fail (#7119) When scanning volume buckets, skip those with unparseable key (#7115)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why, but this fixes 7073 for me. When testing that issue, I noticed that responses would sometimes be empty, even though I could manually request them and they would be full. This looked like an sttp issue, I tried changing the backend, and the empty responses disappeared.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)