Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Thumbnails in Dataset Table #7479

Merged
merged 22 commits into from
Dec 13, 2023
Merged

Show Thumbnails in Dataset Table #7479

merged 22 commits into from
Dec 13, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Dec 5, 2023

Description

  • Introduces new design for the dashboard dataset list:
    • thumbnails replace the "type" column
    • folders and inactive datasets have icons in place of the thumbnails
    • tags are now rendered beneath the dataset name, no longer in a separate column
  • Fixes a backend bug where tags with special characters (" \ ,) would get unexpectedly split

Screenshots

image

URL of deployed dev instance (used for testing):

Steps to test:

  • Open dashboard dataset list, browse around, should look pretty
  • Add and remove tags with and without special characters

TODOs:

  • decide how to handle multi-layer datasets (blending? apply mapping? or select a layer?)
  • backend
    • include layerNames list in APIDatasetCompact
    • avoid duplicated layer names (e.g. connectome_file_test_dataset) (double left join…)
    • fix parsing sql array literals
    • doublecheck that updating view config clears thumbnail cache for that dataset
  • frontend
    • unify tag + name column
    • add thumbnail image
    • user layerNames for thumbnail layer selection
    • styling
      • bigger font? name is more important than tags
      • tweak margins?
      • styling for folders
      • placeholder image for zero-layer datasets
    • remove type column, have folder icon be same size as thumbnails
    • repair dataset to dataset compact function
    • error when entering search query (clearing localstorage helps)
    • have someone who knows how to write frontend code look at it
    • if no tags, add "Add Tag" label to the plus icon
    • less aggressive colors for the tags
    • new placeholder icons

Follow-Up

Issues:


@fm3 fm3 added airbrake and removed airbrake labels Dec 6, 2023
@fm3 fm3 changed the title WIP: Show Thumbnails in Dataset Table Show Thumbnails in Dataset Table Dec 7, 2023
@fm3 fm3 marked this pull request as ready for review December 7, 2023 15:44
@normanrz
Copy link
Member

Sweet!

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool stuff 💯 only left smaller feedback.

frontend/javascripts/types/api_flow_types.ts Outdated Show resolved Hide resolved
frontend/javascripts/types/api_flow_types.ts Outdated Show resolved Hide resolved
Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>
fm3 and others added 3 commits December 12, 2023 18:03
Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>
Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>
@fm3 fm3 requested a review from philippotto December 12, 2023 17:20
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 👍 I'm wondering whether the thumbnails will be a noticable performance hit. The first page of the dataset table can contain up to 50 datasets. This will incur 50 additional requests (can be cached of course). One could think about deferring the loading of a thumbnail (e.g., by a simple delay or by waiting until it is scrolled into view).
However, on the dev instance it's plenty fast. Let's merge it and see how it behaves in production.

@fm3 fm3 enabled auto-merge (squash) December 13, 2023 09:23
@fm3 fm3 merged commit 1140374 into master Dec 13, 2023
2 checks passed
@fm3 fm3 deleted the dataset-table-thumbnails branch December 13, 2023 09:25
@fm3 fm3 mentioned this pull request Dec 13, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show thumbnails in dataset list Parsing dataset tags with special characters is broken again
4 participants