Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all-zero buckets in volume annotation downloads #7576

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 22, 2024

Fixed a bug where all-zero chunks/buckets were omitted when downloading volume annotation even in case of a fallback segmentation layer, where ther zeroed-bucket information is actually needed. Otherwise, it can’t be distinguished if the area should be black or should render the fallback layer data again.

Only “reverted” buckets (marked by a single byte with value zero) are still omitted even in case of fallback segmentation layers.

URL of deployed dev instance (used for testing):

Steps to test:

  • Create volume annotation on a dataset with an existing segmentation layer (e.g. l4_sample)
  • With a large brush size erase a volume comprising multiple buckets (i.e in at least 32 sections)
  • Download that volume annotation, reupload
  • The transparent hole should still be there, and not look like this (old behavior)

Issues:


@fm3 fm3 self-assigned this Jan 22, 2024
@fm3 fm3 marked this pull request as ready for review January 22, 2024 13:47
@fm3 fm3 requested a review from frcroth January 22, 2024 15:08
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@fm3 fm3 enabled auto-merge (squash) January 24, 2024 10:16
@fm3 fm3 merged commit 04de16a into master Jan 24, 2024
2 checks passed
@fm3 fm3 deleted the download-volume-zeroed-buckets branch January 24, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume Annotation Download: keep all-zero chunks to support merging with fallback layer
2 participants