-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Upgrades for Backend Dependencies #7782
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d6618ee
minor upgrades for backend dependencies
fm3 09e9f96
changelog
fm3 711030a
Merge branch 'master' into bump-backend-deps
fm3 579fc5e
Merge branch 'master' into bump-backend-deps
fm3 f66d549
remove outdated test
fm3 98843fa
make the range even more invalid
fm3 6fa6bbb
play released again
fm3 053cc92
Merge branch 'master' into bump-backend-deps
fm3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,7 +68,7 @@ class DataVaultTestSuite extends PlaySpec { | |
"returns failure" when { | ||
"requesting invalid range" in { | ||
val result = (vaultPath / dataKey) | ||
.readBytes(Some(Range.Long(-10, 10, 1)))(globalExecutionContext) | ||
.readBytes(Some(Range.Long(-5, -10, 1)))(globalExecutionContext) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Negative starts for byte ranges are now actually allowed in GCS. So we need to test an even more invalid range to check that a failure is indeed returned (this test is intended to check that no exceptions bubble up but instead the tryo turns them into Box.Failures). |
||
.await(handleFoxJustification) | ||
assertBoxFailure(result) | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/jwt-scala/jwt-scala/releases says no breaking changes, just the play 3 upgrade