Fix animation modal color layer validation #7882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -230,7 +230,8 @@ function CreateAnimationModal(props: Props) { | |||
| cameraPosition: selectedCameraPosition, | |||
| }; | |||
|
|
|||
| if (!validateAnimationOptions(colorLayer, boundingBox, meshes)) return; | |||
| const selectedColorLayer = colorLayers.find((layer) => layer.name === selectedColorLayerName)!; | |||
There was a problem hiding this comment.
line 108 already defines selectedColorLayer, which should be usable here.
cf: line 108: const selectedColorLayer = getLayerByName(dataset, selectedColorLayerName);
There was a problem hiding this comment.
Thus, I'd suggest to remove this line
MichaelBuessemeyer
approved these changes
Jun 14, 2024
MichaelBuessemeyer
added a commit
that referenced
this pull request
Jun 17, 2024
* fix animation modal color layer validation * changelog * rename variable * apply pr feedback * improve error message of uint24 layers in animation modal --------- Co-authored-by: Michael Büßemeyer <michael.buessemeyer@student.hpi.de>
aaronkanzer
pushed a commit
to lincbrain/webknossos
that referenced
this pull request
Jun 17, 2024
* fix animation modal color layer validation * changelog * rename variable * apply pr feedback * improve error message of uint24 layers in animation modal --------- Co-authored-by: Michael Büßemeyer <michael.buessemeyer@student.hpi.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes animation modal color layer validation. Unfortunately, the animation validation would always try the first color layer and not the selected one.
Steps to test:
uint24color layer, submit --> validation erroruint8color layer, submit --> successIssues:
(Please delete unneeded items, merge only when none are left open)