Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix animation modal color layer validation #7882

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Fix animation modal color layer validation #7882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c959bf4
fix animation modal color layer validation
hotzenklotz Jun 14, 2024
48a8507
changelog
hotzenklotz Jun 14, 2024
e64a06b
rename variable
hotzenklotz Jun 14, 2024
78e55e7
apply pr feedback
hotzenklotz Jun 14, 2024
5445c5b
improve error message of uint24 layers in animation modal
MichaelBuessemeyer Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
- Fixed a bug where brushing on a fallback segmentation with active mapping and with segment index file would lead to failed saves. [#7833](https://github.com/scalableminds/webknossos/pull/7833)
- Fixed a bug where sometimes old mismatching javascript code would be served after upgrades. [#7854](https://github.com/scalableminds/webknossos/pull/7854)
- Fixed a bug where dataset uploads of zipped tiff data via the UI would be rejected. [#7856](https://github.com/scalableminds/webknossos/pull/7856)
- Fixed a bug with incorrect valiation of layer names in the animation modal. [#7882](https://github.com/scalableminds/webknossos/pull/7882)

### Removed

Expand Down
6 changes: 3 additions & 3 deletions frontend/javascripts/oxalis/view/action-bar/create_animation_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ function CreateAnimationModal(props: Props) {

const isDtypeSupported = colorLayer.elementClass !== "uint24";
if (!isDtypeSupported)
errorMessages.push("Sorry, animations are not supported for uInt24 datasets.");
errorMessages.push("Sorry, animations are not supported for uInt24 color layers.");

const isDataset3D =
!is2dDataset(state.dataset) && (colorLayer.additionalAxes?.length || 0) === 0;
Expand Down Expand Up @@ -230,7 +230,7 @@ function CreateAnimationModal(props: Props) {
cameraPosition: selectedCameraPosition,
};

if (!validateAnimationOptions(colorLayer, boundingBox, meshes)) return;
if (!validateAnimationOptions(selectedColorLayer, boundingBox, meshes)) return;

startRenderAnimationJob(state.dataset.owningOrganization, state.dataset.name, animationOptions);

Expand Down Expand Up @@ -395,7 +395,7 @@ function CreateAnimationModal(props: Props) {
<Row gutter={[8, 20]}>
<Alert
type="error"
style={{ marginTop: 18 }}
style={{ marginTop: 18, width: "100%" }}
message={
<ul>
{validationErrors.map((errorMessage) => (
Expand Down