Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support source dependencies in sbt-bloop #375

Closed
jvican opened this issue Mar 16, 2018 · 1 comment
Closed

Support source dependencies in sbt-bloop #375

jvican opened this issue Mar 16, 2018 · 1 comment
Labels
integrations work in progress

Comments

@jvican
Copy link
Contributor

jvican commented Mar 16, 2018

Bloop doesn't support source dependencies in sbt because they are tricky to support and there are more important things to work on in the sbt integration. The main issue seems to be that doing bloopInstall applies the project filter in the current build, but not all the source builds loaded by sbt.

This is a ticket to keep track of support of source deps in sbt.
jvican added a commit that referenced this issue Mar 26, 2018
@jvican
Add flag to support source dependencies
f85a081 
The main issue with source deps in Bloop arises from the fact that, by
design, `bloopConfigDir` is build dependent, which means that it changes
across different source deps.

We don't want this to be the case for source dependencies though, since
Bloop needs all the project dependencies to be in the same directory.
For that reason, this flag aggregates the bloop config files to be
written to the same bloop configuration directory, and hence have it
work nicely with bloop.

Fixes #375.
@jvican jvican mentioned this issue Mar 26, 2018
Merged
@jvican
Copy link
Contributor Author

jvican commented Mar 26, 2018

With #394, those that want source dependencies to work with bloop have to do bloopSupportSourceDependencies in Global := true. That will output all the configuration files to the same configuration directory, therefore making Bloop detect the projects of the source deps.

@edrevo edrevo mentioned this issue Aug 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
integrations work in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jvican