Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect --no-color flag #1120

Merged
merged 1 commit into from Dec 15, 2019
Merged

Respect --no-color flag #1120

merged 1 commit into from Dec 15, 2019

Conversation

chessman
Copy link
Contributor

@chessman chessman commented Dec 12, 2019 •
edited

Fixes #1119

@chessman
Copy link
Contributor Author

@jvican Probably failed tests are not related to the changes.

@jvican jvican added bug A defect or misbehaviour. cli community Any change or proposal that is contributed by the Open Source Community. labels Dec 15, 2019
jvican
jvican approved these changes Dec 15, 2019
View reviewed changes
Copy link
Contributor

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @chessman, thanks for the contribution! 👍 I suppose you have checked this yields the expected behavior, let's merge now

@jvican jvican merged commit e589074 into scalacenter:master Dec 15, 2019
@jsatk jsatk mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvican jvican jvican approved these changes

Assignees
No one assigned
Labels
bug A defect or misbehaviour. cli community Any change or proposal that is contributed by the Open Source Community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected color when --no-color flag is used
2 participants
@chessman @jvican