Replace directory hash from loaded analysis #1129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
pushed a commit
to olafurpg/metals
that referenced
this pull request
Dec 18, 2019
Previously, Bloop would trigger a re-compilation after restarting the server. Now, the newly started Bloop server re-uses the cached compilation. Related PR scalacenter/bloop#1129
olafurpg
approved these changes
Dec 18, 2019
There was a problem hiding this comment.
Just tested this locally and can confirm that I'm no longer able to reproduce the re-compilation on a restarted Bloop server when using this PR along with the change in scalameta/metals#1201
The directory hash is random to avoid classpath hash conflicts and it's a value initialized when the bloop server runs for the first time. This means the directory hashes from different bloop instances in time is different. To work around this issue, we make sure we replace the directory hashes from the previous bloop server instance with the new one. This avoid classpath hash invalidations that might trigger recompiles upon restarting the bloop server.
jvican
force-pushed
the
topic/fix-directory-hash
branch
from
cae3a14
to
658006e
Compare
|
This should no longer be necessary, this issue was actually fixed in the latest master but didn't realize that was the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The directory hash is random to avoid classpath hash conflicts and it's
a value initialized when the bloop server runs for the first time. This
means the directory hashes from different bloop instances in time is
different.
To work around this issue, we make sure we replace the directory hashes
from the previous bloop server instance with the new one. This avoid
classpath hash invalidations that might trigger recompiles upon
restarting the bloop server.
Thanks @olafurpg for reporting this misinteraction