Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote the full path for bloop in the generated bat file #1131

Merged
merged 1 commit into from Dec 18, 2019
Merged

Quote the full path for bloop in the generated bat file #1131

merged 1 commit into from Dec 18, 2019

Conversation

er1c
Copy link
Contributor

@er1c er1c commented Dec 18, 2019

@er1c er1c mentioned this pull request Dec 18, 2019
Closed
@jvican jvican changed the title Quote the full path for bloop in the generated bat file - fixes scoop-bloop#5 Quote the full path for bloop in the generated bat file Dec 18, 2019
@jvican jvican added bug A defect or misbehaviour. install windows labels Dec 18, 2019
jvican
jvican approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@jvican jvican merged commit 2d96bcf into scalacenter:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvican jvican jvican approved these changes

Assignees
No one assigned
Labels
bug A defect or misbehaviour. install windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows paths with spaces not supported
2 participants
@er1c @jvican