Don't match on hidden source files #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in #1088, the `HasException` matcher is swallowing up an error that is legit. This error happens because we miss pattern matching on `GlobalError`.
To avoid conflicts when leading with Emacs Interlock files, we whitelist hidden source files from the `SourceWatcher` so that fired modifications on these files are ignored and from the `SourceHasher` so that these files are never discovered and hashed during the `CompileInputs` bundling. Fixes #1088
|
Merging as CI error looks unrelated and published bloop version will be used for testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid conflicts when leading with Emacs Interlock files, we
whitelist hidden source files from the
SourceWatcherso that firedmodifications on these files are ignored and from the
SourceHashersothat these files are never discovered and hashed during the
CompileInputsbundling.Fixes #1088