Fixed providing jvm options in DAP #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alekseiAlefirov
force-pushed
the
dap-jvmoptions
branch
from
fb8650e
to
cd91992
Compare
jvican
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Looks great @alekseiAlefirov Seems like a good catch 👍 I LGTM it but I'm curious, could you try undoing the fix and making sure the test fails?
| @@ -46,7 +46,7 @@ private final class MainClassDebugAdapter( | |||
| env, | |||
| workingDir, | |||
| mainClass.`class`, | |||
| mainClass.arguments.toArray, | |||
| (mainClass.arguments ++ mainClass.jvmOptions).toArray, | |||
There was a problem hiding this comment.
Hmmm, interesting. I thought we were passing the JVM options. Did you double-check that the test passes without this fix?
There was a problem hiding this comment.
yep, it fails without it.
tgodzik
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Thanks for taking a look @alekseiAlefirov ! I can confirm it wasn't working before. This came up when working on the launch.json for VS Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
jvmOptionsinScalaMainClasshave been ignored while running a debug session.Note: not really sure, if the testing is done elegant enough, or can even be put into already existing
test.