Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): bump maxDuration in js tests #1981

Merged
merged 1 commit into from Jul 10, 2023

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Jan 6, 2023

This is consistently failing with messages like:

[error] Test bloop.scalajs.ScalaJsToolchainSpec.canLinkScalaJsProject failed: java.util.concurrent.TimeoutException: Futures timed out after [45 seconds], took 46.973 sec

My naive hope is that just bumping this might make this test less flaky.

@ckipp01 ckipp01 requested review from tgodzik and adpi2 January 6, 2023 14:26
@kpodsiad
Copy link
Collaborator

kpodsiad commented Jan 6, 2023

My 2c, totally without looking what does actually does: 45s is awfully a lot (and 60 even more), what are those tests doing? 😮

@ckipp01
Copy link
Member Author

ckipp01 commented Jan 6, 2023

My 2c, totally without looking what does actually does: 45s is awfully a lot (and 60 even more), what are those tests doing? 😮

You're calling out my laziness. Let me spend a bit more time on them and get a better understanding before I answer that.

@ckipp01 ckipp01 marked this pull request as draft January 6, 2023 16:10
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me! We might need to fix these tests properly at some points. but I haven't looked at them yet.

@tgodzik
Copy link
Contributor

tgodzik commented Jul 7, 2023

I think we can

My 2c, totally without looking what does actually does: 45s is awfully a lot (and 60 even more), what are those tests doing? open_mouth

Btw. looking at this tests again the thing that is happening is:

Non-compiled module 'compiler-bridge_2.11' for Scala 2.11.12. Compiling...
  Compilation completed in 39.365s.

which leaves 6 seconds for the test to finish, which itself invokes other processes, so I think this is safe to bump. What do you think @ckipp01 ? Should we rebase and see if the tests become more stable? I think this is the main cause of flakiness nowadays.,

@ckipp01
Copy link
Member Author

ckipp01 commented Jul 10, 2023

I think we can

My 2c, totally without looking what does actually does: 45s is awfully a lot (and 60 even more), what are those tests doing? open_mouth

Btw. looking at this tests again the thing that is happening is:

Non-compiled module 'compiler-bridge_2.11' for Scala 2.11.12. Compiling...
  Compilation completed in 39.365s.

which leaves 6 seconds for the test to finish, which itself invokes other processes, so I think this is safe to bump. What do you think @ckipp01 ? Should we rebase and see if the tests become more stable? I think this is the main cause of flakiness nowadays.,

Ah good context to have. Yea, honestly I'm fine with this. Let me rebase it and see if everything is 🟢 . I do think it should be pretty safe to bump.

This is consistently failing with messages like:

```
[error] Test bloop.scalajs.ScalaJsToolchainSpec.canLinkScalaJsProject failed: java.util.concurrent.TimeoutException: Futures timed out after [45 seconds], took 46.973 sec
```

My naive hope is that just bumping this might make this test less flaky.
@tgodzik
Copy link
Contributor

tgodzik commented Jul 10, 2023

Looks all green 🎉

@ckipp01 ckipp01 marked this pull request as ready for review July 10, 2023 11:52
@ckipp01 ckipp01 merged commit 0cef362 into scalacenter:main Jul 10, 2023
17 checks passed
@ckipp01 ckipp01 deleted the bumpTIme branch July 10, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants