Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Update scala-debug-adapter from 3.0.5 to 3.0.9 #2011

Merged
merged 1 commit into from Apr 5, 2023

Conversation

scala-center-steward[bot]
Copy link
Contributor

Updates ch.epfl.scala:scala-debug-adapter from 3.0.5 to 3.0.9.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (3.0.5).
You might want to review and update them manually.

integrations/sbt-bloop/src/sbt-test/sbt-bloop/cross-compile-test-configurations/build.sbt
notes/v1.5.5.md
website/yarn.lock
Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "scala-debug-adapter" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "ch.epfl.scala", artifactId = "scala-debug-adapter" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

@adpi2 adpi2 self-requested a review March 16, 2023 15:34
@adpi2 adpi2 self-assigned this Mar 28, 2023
@adpi2 adpi2 marked this pull request as draft March 28, 2023 15:59
@adpi2 adpi2 force-pushed the update/scala-debug-adapter-3.0.9 branch 7 times, most recently from f367d1e to f3398a5 Compare March 29, 2023 09:50
@adpi2
Copy link
Member

adpi2 commented Mar 29, 2023

Found out that the first test in DebugProtocolSpec fails systematically because configuring the debug context takes more than 30s. This only happens on JDK 11, on Ubuntu or Windows. It does not happen on any other JDK, nor on Mac. Configuring the debug context a second time is much faster:

[Debugger][Info]Configured debugger context in 50 seconds
Wed Mar 29 09:57:57 UTC 2023 server started
Wed Mar 29 09:57:57 UTC 2023 server listening on tcp://0.0.0.0:37597
[Debugger][Info]Configured debugger context in 1 second

Could it be that there is a starvation of threads on the first run only? Could it be that we need to warm up some class loader?

As I was not able to reproduce this error locally, I am going to add more logs in the debugger to understand what's happening.

@adpi2 adpi2 force-pushed the update/scala-debug-adapter-3.0.9 branch 2 times, most recently from 28edbbd to 9908a48 Compare March 29, 2023 13:05
@adpi2 adpi2 force-pushed the update/scala-debug-adapter-3.0.9 branch from 4541495 to b7d25b3 Compare April 4, 2023 14:06
@adpi2 adpi2 marked this pull request as ready for review April 4, 2023 14:06
@adpi2 adpi2 merged commit 883f5f6 into main Apr 5, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant