Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Update zinc from 1.8.1 to 1.9.1 #2064

Merged
merged 4 commits into from Jun 29, 2023
Merged

Conversation

scala-center-steward[bot]
Copy link
Contributor

Updates org.scala-sbt:zinc from 1.8.1 to 1.9.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (1.8.1).
You might want to review and update them manually.

notes/v1.5.5.md
website/yarn.lock
Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "zinc" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-sbt", artifactId = "zinc" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, old-version-remains, commit-count:1

@scala-center-steward
Copy link
Contributor Author

Superseded by #2079.

@tgodzik
Copy link
Contributor

tgodzik commented Jun 23, 2023

I changed the tests since they were timing out on compilation (might be due to large bridges being compiled not sure)

@tgodzik tgodzik changed the title build(deps): Update zinc from 1.8.1 to 1.9.0 build(deps): Update zinc from 1.8.1 to 1.9.1 Jun 23, 2023
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! One thing that was added to sbt 1.9.0 is the actions inside of Problem. In the Bloop Problem.scala we aren't actually taking this into account yet. Are you able to add it and then also forward it on? If not after we merge this I can also add it in in another pr, but it should be pretty quick to add.

@tgodzik
Copy link
Contributor

tgodzik commented Jun 26, 2023

This looks good! One thing that was added to sbt 1.9.0 is the actions inside of Problem. In the Bloop Problem.scala we aren't actually taking this into account yet. Are you able to add it and then also forward it on? If not after we merge this I can also add it in in another pr, but it should be pretty quick to add.

Hmm... do we put the bsp.ScalaAction into data field (from what I see in your metals PR)? Shouldn't that be a list?

@ckipp01
Copy link
Member

ckipp01 commented Jun 26, 2023

Hmm... do we put the bsp.ScalaAction into data field (from what I see in your metals PR)? Shouldn't that be a list?

Correct, it will be a list of actions, but when it's coming from Problem it will be a list, and then we'll turn data into an object aka bsp.ScalaDiagnostic where this list is nested under actions. Then in my metals pr in the DiagnosticDataDeserializer I check for actions and if so deserialize it to bsp.ScalaDiagnostic which holds the actions.

@ckipp01
Copy link
Member

ckipp01 commented Jun 26, 2023

Also here is the PR for sbt if it helps to see how it was done there. sbt/sbt#7264

@tgodzik
Copy link
Contributor

tgodzik commented Jun 27, 2023

Also here is the PR for sbt if it helps to see how it was done there. sbt/sbt#7264

Ok, I think it's done! Let me know if it makes sense.

@tgodzik tgodzik requested a review from ckipp01 June 27, 2023 10:05
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just one quick question.

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me! Thanks for taking care of this!

@tgodzik tgodzik merged commit 307c913 into main Jun 29, 2023
16 of 17 checks passed
@tgodzik tgodzik deleted the update/zinc-1.9.0 branch June 29, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants