feat: fallback to source and javadoc classifiers when exporting projects from sbt
#2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
kpodsiadlo/export-sources-from-sbt
branch
from
a48818e
to
8fe341f
Compare
|
Hmm... I tried rebase but broke something, let fix that in sec. |
tgodzik
force-pushed
the
kpodsiadlo/export-sources-from-sbt
branch
from
8fe341f
to
ea971c7
Compare
tgodzik
force-pushed
the
kpodsiadlo/export-sources-from-sbt
branch
from
ea971c7
to
1a83daa
Compare
Seems like my change broke something in classifiers? I'll have a look at it tomorrow. |
kpodsiad
changed the title
source when exporting projects from sbtsource and javadoc classifiers when exporting projects from sbt
|
@tgodzik it seems that |
tgodzik
approved these changes
Jul 18, 2023
kpodsiad
commented
Oct 18, 2023
| @@ -144,6 +144,7 @@ object BloopDefaults { | |||
| Option(System.getProperty("bloop.export-jar-classifiers")) | |||
| .orElse(Option(System.getenv("BLOOP_EXPORT_JAR_CLASSIFIERS"))) | |||
| .map(_.split(",").toSet) | |||
| .orElse(Some(Set("sources", "javadoc"))) | |||
There was a problem hiding this comment.
@tgodzik sources classifier is useful for metals, but is javadoc useful? I do wonder if this isn't too much, wdyt?
There was a problem hiding this comment.
It might be useful in some potential cases, though it's unused currently in Metal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a power user I often use
bloopInstallfrom already opened sbt session as it is much faster thanMetals: Import Build(warm JVM with sbt, etc.). However, there is one main advantage thatMetals: Import Buildhas - it runs sbt with-Dbloop.export-jar-classifiers=sources.Even though it is possible to configure bloop's sbt plugin to download sources, by tweaking build.sbt I don't consider it as a viable option because:
Not having sources for dependencies results in really bad UX in Metals, as they can't e.g. go to the definition of given class. They instead fail silently, or go to the completely different class which happens to have the same symbol name.
I do understand that this may lead to slightly longer downloading times, but I think it's better to sacrifice a bit of time once, rather than UX every time when there are no sources.