specify scip javac plugin targetroot exactly #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
approved these changes
Aug 1, 2023
tgodzik
added a commit
to tgodzik/bloop
that referenced
this pull request
Aug 30, 2023
…ac_target_root" This reverts commit a3a78de, reversing changes made to 041a90b. It seems to have caused scalacenter#2140
tgodzik
added a commit
that referenced
this pull request
Aug 30, 2023
Revert "Merge pull request #2128 from Arthurm1/specify_javac_target_root"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Bloop uses
-targetroot:javac-classes-directoryto specify thetargetrootdir for thescip-javaplugin, which means Bloop delegates to the plugin to work out the correct dir to place the semanticdb files in.scip-javahas to use the internal JDK API to perform the substitution which requires--add-exportsand I see no way round that - hence in this PR Bloop specifies the exact classes directory