Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BSP buildTargetDependencyModules #2197

Merged
merged 1 commit into from Nov 21, 2023
Merged

Implement BSP buildTargetDependencyModules #2197

merged 1 commit into from Nov 21, 2023

Conversation

Arthurm1
Copy link
Contributor

DependencyModules is an improvement on DependencySources

tgodzik
tgodzik approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we had some issues in the past that could have been solved by this, but I don't really remember (bsp part might have been an effort to help us)

@tgodzik tgodzik merged commit 6cb81c3 into scalacenter:main Nov 21, 2023
17 checks passed
@Arthurm1 Arthurm1 deleted the dependency_modules branch November 21, 2023 15:02
@fthomas fthomas mentioned this pull request Dec 8, 2023
Open
@fthomas fthomas mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arthurm1 @tgodzik