Sync nailgun on 2018-02-27 #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this the upgrade to the new nailgun version? |
|
Yes, this rebases our changes on the current master in facebook/nailgun. |
|
Have you double-checked this change locally and used it? I think we should dogfood it first before merging it, given how severe the upstream changes have been. |
|
I haven't tried it a lot, it seemed to work, and the nailgun tests seemed happy too. |
|
Thanks for taking care of this, I will battle test it locally to be sure our users are not affected. Will get back to this PR soon. |
This was referenced Mar 5, 2018
jvican
force-pushed
the
topic/upgrade-nailgun
branch
from
2b06335
to
a3f5bfc
Compare
Co-authored-by: Duhemm <martin.duhem@gmail.com> Co-authored-by: Jorge Vicente Cantero <jorgevc@fastmail.es>
jvican
force-pushed
the
topic/upgrade-nailgun
branch
from
6e4fefa
to
47781c1
Compare
|
I have updated nailgun to a version that includes a fix for #209, then released the version and changed it in our build. Let's merge this when CI is green. |
|
LGTM 👍 |
jvican
approved these changes
Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.