Change the organization of the integration builds #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duhemm
requested changes
Nov 15, 2017
| val globalSettings = | ||
| List(Keys.onLoadMessage in sbt.Global := s"Setting up the integration builds.") | ||
| def genProjectSettings(ref: sbt.ProjectRef) = | ||
| BuildKeys.inProject(ref)(Keys.organization := "ch.epfl.scala") |
There was a problem hiding this comment.
If we're changing the organisation here, we probably also need to tell the component compiler to use a different organisation when resolving the bridge sources.
We have our own bridge version, and we want to be able to resolve it independently of what sbt's bridge version is.
jvican
force-pushed
the
topic/nailgun
branch
from
ee17e93
to
423a436
Compare
|
I've double-check that this does not break |
jvican
changed the title
Duhemm
approved these changes
Nov 16, 2017
| case sc if (sc startsWith "2.10.") => "compiler-bridge_2.10" | ||
| case sc if (sc startsWith "2.11.") => "compiler-bridge_2.11" | ||
| case sc if (sc startsWith "2.12.") => "compiler-bridge_2.12" | ||
| case _ => "compiler-bridge_2.13" |
There was a problem hiding this comment.
It would be cool to support Dotty too someday. Maybe that we should put the compiler bridge source in the configuration file?
There was a problem hiding this comment.
I thought about the same 😄. Sounds good to me, mind opening a ticket?
Closed
tpasternak
pushed a commit
to tpasternak/bloop
that referenced
this pull request
Dec 23, 2021
* Remove sockets module * Use ipcsocket fork * Use ipcsocket tweaked fork * Empty commit to trigger CI * Empty commit to trigger CI * Empty commit to trigger CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.