Use fixed size thread pool for task execution #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were many problems with the global execution context with nailgun. I tried that, and it makes logging and task execution work again with Nailgun.
jvican
approved these changes
Nov 28, 2017
| import java.util.concurrent.Executors | ||
|
|
||
| object ExecutionContext { | ||
| private val nCPUs = Runtime.getRuntime.availableProcessors() |
There was a problem hiding this comment.
We should make this configurable down the road, mind creating a ticket for it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were many problems with the global execution context with nailgun.
I tried that, and it makes logging and task execution work again with
Nailgun.