Add masterAdm command #33
Conversation
- This initial version of masterAdm add support for exercise renumbering in a course master repository
| @@ -595,6 +595,32 @@ Untracked files: | |||
| nothing added to commit but untracked files present (use "git add" to track) | |||
| ``` | |||
|
|
|||
| ### masterAdm | |||
There was a problem hiding this comment.
I don't understand the naming of the command. Why not just call it "renumber"?
There was a problem hiding this comment.
Because I think there will be other features that will be added to this single master admin command which will be selectable (and perhaps combined with) form a list of features.
There was a problem hiding this comment.
Would it be better to either a) Implement those other features using different commands, or b) Deal with that problem once it comes up?
Just concerned that right now all we need is a renumber so why not call it that. Later as new things are required we can look at introducing them and how to introduce them, but for now we don't have a use case.
There was a problem hiding this comment.
I have a few things in mind, but wanted to get started, hence the name of this command. Other things:
- Delete a range or ranges of exercises
- Create a gap of a given size @ a certain exercise number
- Create a gap @ a certain exercise and duplicate the code from previous or next exercise.
- ...
There was a problem hiding this comment.
@WadeWaldron @rgcase Wanted to keep things as simple as possible in this version. The general idea behind this implementation was to be able to delete exercises:
- Delete exercise_xxx_* folders and just run masterAdm -r
- Add exercises by creating gaps where needed, add new exercise folders at the appropriate location and run masterAdm -r
That would do the trick for adding and deleting exercises.
Can create commands as requested for sure, but wanted to spend time on other things first.
|
I'm curious why you didn't just implement the command to do "delete exercise_XYZ" and "insert gap after exercise_XYZ". This seems more complicated and requires an extra renumbering step when you're finished. |
| val exercises: Vector[String] = getExerciseNames(masterRepo) | ||
| val ExerciseNameSpec(_, firstExerciseNr, _) = exercises.head | ||
| val (exercisesRenumbered: Vector[String], _) = | ||
| (exercises foldLeft(Vector.empty[String], renumberOffset)) { |
There was a problem hiding this comment.
Maybe I don't understand but this seems to be pushing the first exercise up by renumberOffset then adding gaps of size renumberDelta. I thought you meant to only start the gaps at index renumberOffset?
If the former is what you want, then can't we just skip the renumberOffset and offset everything by renumberDelta?
There was a problem hiding this comment.
Yes, that would be possible too. The idea behind renumberOffset was to be able to add exercises in front of the first exercise. Of course, just using renumberDelta and starting the first renumbered exercise at renumberDelta instead of 0 would sort of achieve the same result.
|
Superseded by PR #55. |
* removed the explicit strings from the test specs * refactored into packages * refactored client to match admin test packages * added outline client cli command specs (#34)
renumbering in a course master repository