Toward a machine-independent incremental cache file #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gontard
force-pushed
the
caching_style
branch
2 times, most recently
from
82d2605
to
438f418
Compare
bjaglin
reviewed
Feb 16, 2021
build.sbt
Outdated
| @@ -92,5 +92,6 @@ sbtPlugin := true | |||
| scriptedBufferLog := false | |||
| scriptedLaunchOpts ++= Seq( | |||
| "-Xmx2048M", | |||
| s"-Dplugin.version=${version.value}" | |||
| s"-Dplugin.version=${version.value}", | |||
| "-Dsbt-scalafix.uselastmodified=true" | |||
There was a problem hiding this comment.
Suggested change
| "-Dsbt-scalafix.uselastmodified=true" | |
| "-Dsbt-scalafix.uselastmodified=true" // the caching scripted relies on sbt-scalafix only checking file attributes, not content |
There was a problem hiding this comment.
👍 I don't have a better idea than changing the style for scripted (and I think a system property is better/more hidden than a setting key), as
would no longer work by default: with hashing, a file access won't necessarily mean that the file is being read by protoc (but just hashed beforehand).
gontard
force-pushed
the
caching_style
branch
4 times, most recently
from
e74ac0c
to
800bd90
Compare
bjaglin
reviewed
Feb 17, 2021
gontard
force-pushed
the
caching_style
branch
2 times, most recently
from
df9afba
to
2ae3d1b
Compare
* Switch from lastModified to hash caching style in order to produce machine-independent file stamps once sbt/sbt#6298 will solved. * Add a system property "sbt-scalafix.uselastmodified" to force the use of the lastModified caching style. (Used in scripted tests)
Stamps scalafix arguments using a hash of the files instead of relying on the lastMofified property in order to produce a machine-independent "args" cache.
gontard
force-pushed
the
caching_style
branch
from
2ae3d1b
to
8ff37a3
Compare
bjaglin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective is to produce a machine-independent cache in order to include sbt-scalafix cache files in the remote cache artifact.
Two things are missing:
hashinstead oflastModifiedstyle for cache stamping.This PR solves the second point.
To make the scripted tests green, i had to permit to get back the previous behaviour (
lastModified). Done with a system property.