Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please publish for Scala 2.13.12 #1860

Closed
SethTisue opened this issue Sep 6, 2023 · 2 comments · Fixed by scalacenter/sbt-scalafix#368
Closed

Please publish for Scala 2.13.12 #1860

SethTisue opened this issue Sep 6, 2023 · 2 comments · Fixed by scalacenter/sbt-scalafix#368

Comments

@SethTisue
Copy link
Contributor

...which is now on Maven Central, as per https://contributors.scala-lang.org/t/scala-2-13-12-release-planning/6217/26

@bjaglin
Copy link
Collaborator

bjaglin commented Sep 7, 2023

Thanks for the ping!

FTR, from the discussion in discord:

for 99,999% of the users, the only benefit of publishing a new "scalafix release" in sync with each new scala 2.x patch release is for sbt-scalafix (which currently has a coupled release cycle with scalafix, see #1146) to automatically bring-in a release of scalameta that has a semanticdb-scalac available for that version (via the semanticdbVersion := scalafixSemanticdb.revision recommendation in the docs).

However,

  • The user could just update to the latest manually. I am actually planning to tweak in sbt-scalafix the error messages related to a missing semanticdb-scalac to reduce the impact of the new publishing policy of scalameta (see https://discordapp.com/channels/632642981228314653/632642981228314657/1131223392679378994 / Update scalameta to 4.8.8 #1846 (comment))
  • As @tomasz Godzik mentioned, semanticdb-scalac is now backpublished. That said, we happen to be on an old 4.7.x scalameta version in the latest scalafix release (funny enough, due to lack of time on my side for that scalameta publishing change described above). And it turns out that the backpublishing was not done, so this time around we would need a new release anyway 🤷‍♂️

So I'll publish a new sbt-scalafix/scalafix release by Monday (official release of 2.13.12), but the next scala 2.x release won't really need a embargo-synchronized scalafix release considering the 2 items below shouuld be "solved" by then.

@bjaglin
Copy link
Collaborator

bjaglin commented Sep 7, 2023

the next scala 2.x release won't really need a embargo-synchronized scalafix release considering the 2 items below shouuld be "solved" by then.

I just got an exception that proved me wrong 😅 It turns out that 2.13.12 has a "breaking" change that makes one rule regress as it depends too much compiler internals (through semanticdb diagnostics), so we can't guarantee this won't happen again next time... But at least we can check during the embargo period, and decide not to release anything right away if built-in rules don't need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants