use & support scala 2.13.12 #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
21312
branch
5 times, most recently
from
3637ed9
to
2e7a113
Compare
bjaglin
commented
Sep 7, 2023
Comment on lines
+146
to
+147
| case i @ Defn.Def(_, name, _, _, _, _) if isUnusedTerm(name.pos) => | ||
| defnTokensToRemove(i).map(Patch.removeTokens).asPatch.atomic |
There was a problem hiding this comment.
Compiler warnings for defs are now emitted on a more narrow tree.
--- metap ./scalafix-tests/input/target/jvm-2.13.11/meta/META-INF/semanticdb/scalafix-tests/input/src/main/scala-2/test/removeUnused/RemoveUnusedTerms.scala.semanticdb
+++ metap ./scalafix-tests/input/target/jvm-2.13.12/meta/META-INF/semanticdb/scalafix-tests/input/src/main/scala-2/test/removeUnused/RemoveUnusedTerms.scala.semanticdb
Diagnostics:
-[7:10..7:10) [warning] procedure syntax is deprecated: instead, add `: Unit =` to explicitly declare `foo`'s return type
+[7:10..7:10) [warning] procedure syntax is deprecated: instead, add `: Unit =` to explicitly declare `foo`'s return type [quickfixable]
[8:4..8:20) [warning] local val a in method foo is never used
[9:4..9:23) [warning] local val aa in method foo is never used
[10:4..10:13) [warning] local var b in method foo is never used
[11:4..11:23) [warning] local var bb in method foo is never used
-[13:4..13:20) [warning] local method c in method foo is never used
+[13:8..13:9) [warning] local method c in method foo is never used
-[14:4..14:25) [warning] local method cc in method foo is never used
+[14:8..14:10) [warning] local method cc in method foo is never used
[15:4..15:15) [warning] local val xy in method foo is never used
-[20:2..20:35) [warning] private method ff in object RemoveUnusedTerms is never used
+[20:14..20:16) [warning] private method ff in object RemoveUnusedTerms is never used
bjaglin
commented
Sep 7, 2023
Comment on lines
144
to
145
| case i: Defn if isUnusedTerm(i.pos) => | ||
| defnTokensToRemove(i).map(Patch.removeTokens).asPatch.atomic |
There was a problem hiding this comment.
Keeping the old matcher for compatibility with semanticdb generated with compiler <2.13.12.
bjaglin
commented
Sep 7, 2023
| @@ -43,11 +43,11 @@ class RuleCompiler( | |||
| List(new BatchSourceFile(label, new String(input.chars))) | |||
| ) | |||
| val errors = reporter.infos.collect { | |||
| case reporter.Info(pos, msg, reporter.ERROR) => | |||
| case r: reporter.Info if r.severity == reporter.ERROR => | |||
There was a problem hiding this comment.
avoid using unapply as signature is now inconsistent between 2.12 and 2.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1860