Add test for 2.11 and 2.13 version of ExplicitResultType #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
reviewed
Jun 18, 2020
| @@ -0,0 +1,56 @@ | |||
| package tests | |||
There was a problem hiding this comment.
so this one doesn't work on scala 2.11?
There was a problem hiding this comment.
I forgot this. I will check
bjaglin
reviewed
Jun 18, 2020
...fix-tests/output/src/main/scala-2.11/test/explicitResultTypes/ExplicitResultTypesInfix.scala
Show resolved
Hide resolved
bjaglin
reviewed
Jun 18, 2020
scalafix-tests/input/src/main/scala/test/explicitResultTypes/Rename.scala
Show resolved
Hide resolved
bjaglin
reviewed
Jun 18, 2020
scalafix-tests/input/src/main/scala/tests/ExplicitResultTypesRefinement.scala
Show resolved
Hide resolved
bjaglin
reviewed
Jun 18, 2020
Comment on lines
320
to
324
| if (productRootClass | ||
| .intersect(parents.map(_.typeSymbol).toSet) | ||
| .nonEmpty && parents | ||
| .map(_.typeSymbol) | ||
| .contains(serializableClass)) { |
There was a problem hiding this comment.
could you extract val parentsClass = parents.map(_.typeSymbol).toSet to make the condition more readable?
The code was not matching both Serializable trait in 2.13 and 2.12, which was leading to cases where got types that are not symplified enought. in 2.13, only one serializable remains, which was leading to unwanted simplification (ex: Serializable, AnyRef => AnyRef)
bjaglin
reviewed
Jun 19, 2020
scalafix-tests/output/src/main/scala/test/explicitResultTypes/Rename.scala
Show resolved
Hide resolved
bjaglin
approved these changes
Jun 19, 2020
scalafix-rules/src/main/scala/scalafix/internal/rule/CompilerTypePrinter.scala
Show resolved
Hide resolved
scalafix-rules/src/main/scala/scalafix/internal/rule/CompilerTypePrinter.scala
Outdated
Show resolved
Hide resolved
…ypePrinter.scala Co-authored-by: Brice Jaglin <bjaglin@gmail.com>
…Rename.scala Co-authored-by: Brice Jaglin <bjaglin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #998