Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalafix-core_3 (GSoC 2022) #1629

Merged
merged 25 commits into from
Jul 22, 2022
Merged

scalafix-core_3 (GSoC 2022) #1629

merged 25 commits into from
Jul 22, 2022

Conversation

rvacaru
Copy link
Contributor

@rvacaru rvacaru commented Jul 6, 2022

This PR is the first step towards adapting ExplicitResultTypes for scala3 #1583 and part of the plan for scala3 support #1680. The idea is to cross compile all scalafix modules to scala3 and then introduce a new ExplicitResultTypes implementation for scala3.

Screenshot 2022-07-22 at 12 03 53

In this first step we're cross compiling scalafix-core to scala3

@rvacaru

This comment was marked as resolved.

@rvacaru rvacaru force-pushed the scala-3 branch 2 times, most recently from 4a5490b to dd956df Compare July 14, 2022 08:54
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
project/Dependencies.scala Outdated Show resolved Hide resolved
project/ScalafixBuild.scala Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
@bjaglin
Copy link
Collaborator

bjaglin commented Jul 15, 2022

Another note: since core3 is an orphan modules not used by any other, I don't think its compilation is covered by CI, so you should add an explicit unit3/compile in

commands += Command.command("ci-3") { s =>
"unit2_12Target3/test" ::
s
},

This will apply for all xxx3 modules until we move unit2_12Target3 to unit3.

Copy link
Collaborator

@bjaglin bjaglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round of comments, and we'll be good to go (provided core3/compile is green!)

project/ScalafixBuild.scala Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
@rvacaru rvacaru force-pushed the scala-3 branch 2 times, most recently from 1fc6675 to c88e7be Compare July 21, 2022 14:55
@rvacaru rvacaru marked this pull request as ready for review July 22, 2022 08:21
@bjaglin bjaglin merged commit d6645da into scalacenter:main Jul 22, 2022
@bjaglin bjaglin changed the title Scalafix-core compiled in Scala 3 scalafix-core_3 Oct 2, 2022
@bjaglin bjaglin changed the title scalafix-core_3 scalafix-core_3 (GSoC 2022) Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants