Enable scalafix in the scalafix build. #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove ununsed imports and terms.
| @@ -126,7 +126,7 @@ object TestProject { | |||
| MultiScalaProject( | |||
| s"tests${sub.capitalize}", | |||
| base(sub), | |||
| configure | |||
| configure.andThen(_.disablePlugins(scalafix.sbt.ScalafixPlugin)) | |||
| @@ -0,0 +1,4 @@ | |||
| rules = [ | |||
There was a problem hiding this comment.
explicit return type for public methods?
|
It would be nice to add a --test in the ci matrix. |
We limit .scalafix.conf to implicits only. Running ExplicitResultTypes on public members yielded several known bugs.
|
We run --test in the ci-fast-212 entry @MasseGuillaume https://travis-ci.org/scalacenter/scalafix/jobs/319146392#L942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think long overdue to bootstrap and start using scalafix to develop scalafix 😄 We can start with remove unused imports and terms and then add more as we go. I found NoInfer to be too noisy, I will soon have a PR making it possible to tweak the noise by excluding certain symbols.