Add support to disable symbol via regex #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
suggested changes
Apr 3, 2018
| import scala.collection.mutable // ok | ||
|
|
||
| @SuppressWarnings(Array("Disable.ListBuffer")) | ||
| @SuppressWarnings(Array("Disable.<init>")) |
There was a problem hiding this comment.
I propose we either
- ignore constructors (skip when name is
<init>), or - give
Disable.<init>a more helpful name such asListBuffer.<init>
I vote for the first option since you can't reference a constructor without referencing the enclosing type. Having to disable twice is annoying.
| @SuppressWarnings(Array("Disable.mutable")) | ||
| @SuppressWarnings(Array("Disable.HashMap")) | ||
| @SuppressWarnings(Array("Disable.<init>")) | ||
| val abc = new mutable.HashMap[String, String]() |
There was a problem hiding this comment.
Intuitively, there is only one symbol being referenced here HashMap.<init> so I think it's a bit weird that three errors are reported.
I think it would make sense to skip the qualifier of a Term.Select if it only contains Term.Select or Term.Name.
a.b.C // only report on C
d.E // only report on E
f.g(1).h // report on h and gIt should be simple to do this check with something like
def skipQualifier(qual: Term) Boolean = qual match {
case _: Term.Name => true
case Term.Select(q, _) => skipQualifier(q)
}
Closed
olafurpg
suggested changes
Apr 9, 2018
| @@ -29,12 +29,9 @@ object DisableRegex { | |||
| import scala.collection.mutable // ok | |||
|
|
|||
| @SuppressWarnings(Array("Disable.ListBuffer")) | |||
| @SuppressWarnings(Array("Disable.<init>")) | |||
| val buffer = new ListBuffer[Int]() | |||
There was a problem hiding this comment.
What happens if you have a more complex qualifier in a select?
a.b(1).c
and a and c are banned? I would expect there to be two lint errors
a.b(1).c
^
a.b(1).c
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
OrphanImplicitsfrom #635, since it's not going to be merged soon...