Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable should report error on banned symbols in select chains #679

Closed
olafurpg opened this issue Apr 11, 2018 · 4 comments
Closed

Disable should report error on banned symbols in select chains #679

olafurpg opened this issue Apr 11, 2018 · 4 comments
Assignees

Comments

@olafurpg
Copy link
Contributor

olafurpg commented Apr 11, 2018

Consider the snippet a.banned1(1, 2).c.banned2. If the user has configured Disable to report an error on symbols banned1 and banned2 then I would expect two errors to be reported. Changes in #669 may introduce a bug so that only one error is reported, I am not 100% but we should at least add a test case for this scenario.

a.banned1(1, 2).c.banned2
  ^

a.banned1(1, 2).c.banned2
                  ^

@vovapolu
Copy link
Contributor

Everything works fine :) Current implementation skips only a.b.c.d cases, e.g. reports only on the last disabled symbol. For example if we disable a and c, then it will report only on c, if we disable a, b, d it will report only on d. It doesn't affect on more complex Term.Select chains.

vovapolu added a commit to vovapolu/scalafix that referenced this issue Apr 11, 2018
@olafurpg
Copy link
Contributor Author

Can you send a PR adding a test for a.banned1(2).banned2?

@vovapolu
Copy link
Contributor

:D done

@olafurpg
Copy link
Contributor Author

Fixed in #691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants