Support reading all sorts of refinement types. #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only `TypeMember`s, `ValDef`s and `DefDef`s are allowed there.
bishabosha
reviewed
Dec 1, 2022
|
|
||
| // Read infos -- skip names | ||
| def readParamInfos()(using LocalContext): List[PInfo] = | ||
| paramInfosUnpickler.reader.until(end) { |
There was a problem hiding this comment.
this looks like it would try to readInfo when the next byte is the mods
There was a problem hiding this comment.
this example causes unexpected type tag GIVEN error (reading the inferred type of givenRefinement, stack trace includes TreeUnpickler.scala:1117):
// test-sources/src/main/scala/simple_trees/Function.scala
class Function {
...
val givenRefinement = ??? : { def foo(using Int): Int }
}There was a problem hiding this comment.
Oh nice catch! It's fixed now.
bishabosha
requested changes
Dec 1, 2022
Including their members which can contain RECthis, METHODtype, and POLYtype. Fix scalacenter#6, fix scalacenter#16, fix scalacenter#20, fix scalacenter#21.
sjrd
force-pushed
the
read-all-refinement-types
branch
from
4d4fe01
to
527ade5
Compare
bishabosha
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including their members which can contain RECthis, METHODtype, and POLYtype.
Fix #6, fix #16, fix #20, fix #21.
This is not enough for #213 yet, since they are not handled correctly in member selection nor subtyping yet.