Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash blocks are incorrectly indented when nesting #553

Merged
merged 4 commits into from
Aug 31, 2021

Conversation

keynmol
Copy link
Collaborator

@keynmol keynmol commented Aug 27, 2021

Reproduces and fixes #552.

I introduced this regression in #551. There's actually two bugs in here -

  • incorrectly passing the indentation level to the code inside definition and
  • undoing the indentation-aware codeprinter's work by adding a newline myself 🤦

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge and release without my review, as long as CI is green

clue
)
}

private def processOutput(raw: String) =
raw.replaceAll("\t", " ")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was absolutely losing my mind staring at the useless diffs. If this is over the top, let me know and I will remove.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine 👍

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keynmol keynmol merged commit 452f1c4 into scalameta:main Aug 31, 2021
@keynmol keynmol deleted the fix-crash-blocks-again branch August 31, 2021 14:21
fdietze pushed a commit to fdietze/mdoc that referenced this pull request Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug/Regression of Crash blocks in 2.2.23
3 participants