Upgrade the Monaco Editor to version 0.9.0 #49
Conversation
The facade is generated with sjrd/scala-js-ts-importer#a2a2ce740d66adeb9fb53b7be7799dfe402febab which uses `def` instead of `val` for readonly fields compared to the facade generated for 0.8.3.
jonas
force-pushed
the
monaco-editor-0.9.0
branch
from
41c7ab3
to
7e15027
Compare
ITextModelResolverService was renamed to ITextModelService in Microsoft/vscode#337ded059ae5140b86caf07e67ce92a41a8e6581.
| model: editor.IReadOnlyModel, | ||
| position: Position, | ||
| token: CancellationToken | ||
| ): Definition | Thenable[Definition] = js.native |
There was a problem hiding this comment.
Does this support jumping to a symbol in another file.
There was a problem hiding this comment.
I think so yes:
The type definition provider interface defines the contract between extensions and the go to type definition feature.
There was a problem hiding this comment.
It seems this was different than I initially thought. "Go to type" seems to be a way to jump to the type definition when the cursor is lying above a term/pattern (non-type symbol). Example,
val x = List(1)"Go to type" on the variable x will jump to the List symbol. Context microsoft/TypeScript#10394
I was hoping it was a global "Jump to type" search, but it's pretty useful nevertheless.
| var accessibilitySupport: String = js.native | ||
| var quickSuggestions: Boolean | js.Any = js.native | ||
| var quickSuggestionsDelay: Double = js.native | ||
| var parameterHints: Boolean = js.native |
There was a problem hiding this comment.
I think it is related with the SignatureHelpProvider
The signature help provider interface defines the contract between extensions and the parameter hints-feature.
There was a problem hiding this comment.
Nice. Although I guess that provider does not make sense with read-only mode.
The facade is generated with
sjrd/scala-js-ts-importer#a2a2ce740d66adeb9fb53b7be7799dfe402febab which
uses
definstead ofvalfor readonly fields compared to the facadegenerated for 0.8.3.
Comes with a nice overview of the current file and a new TypeDefinitionProvider API.