Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript - ability to go to type definition #10394

Closed
waderyan opened this issue Aug 17, 2016 · 4 comments
Closed

TypeScript - ability to go to type definition #10394

waderyan opened this issue Aug 17, 2016 · 4 comments
Labels
External Relates to another program, environment, or user action which we cannot control. VS Code Tracked There is a VS Code equivalent to this issue

Comments

@waderyan
Copy link

From @wallverb on August 12, 2016 22:36

  • VSCode Version: Code - Insiders 1.5.0-insider (e9c80f036645caae7759b3954fc72dbe6c644edf, 2016-08-12T06:04:09.471Z)
  • OS Version: Darwin x64 15.6.0

Steps to Reproduce:

interface Test {
}

const test:Test = {}
const test2 = test 

If your cursor is inside Test of const test:Test you can click F12 to go to that type definition - but sometimes you do not have type declared explicitly (infered type) - eg. const test2 then it's impossible to go easily to type defintion. Maybe combination of some key + click (or extra entry in popup) Go to type definition

Copied from original issue: microsoft/vscode#10489

@waderyan
Copy link
Author

@dbaeumer this looks like a valid feature request? Is this something provided by VS Code or by Salsa?

@waderyan
Copy link
Author

From @dbaeumer on August 17, 2016 15:25

Nice idea.

@waderyan in these cases I do the following: I create a issue against TS and link to it from a VS Code issue (this one). I keep this one as a feature request on our end.

@waderyan
Copy link
Author

From @dbaeumer on August 17, 2016 15:26

May be we need a depends-on label to mark these.

@mhegazy
Copy link
Contributor

mhegazy commented Aug 17, 2016

TypeScript has a goto type command available on the tsserver, see https://github.com/Microsoft/TypeScript/blob/master/src/server/protocol.d.ts#L188.

VSCode needs to expose a new shortcut that calls into this command.

@mhegazy mhegazy added the External Relates to another program, environment, or user action which we cannot control. label Aug 17, 2016
@waderyan waderyan added the VS Code Tracked There is a VS Code equivalent to this issue label Sep 22, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
External Relates to another program, environment, or user action which we cannot control. VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

No branches or pull requests

3 participants