Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions to support Scala Native #104

Merged
merged 7 commits into from
Apr 8, 2021

Conversation

ekrich
Copy link
Contributor

@ekrich ekrich commented Apr 2, 2021

No description provided.

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thank you!

@ekrich
Copy link
Contributor Author

ekrich commented Apr 3, 2021

Thanks @olafurpg, we are waiting on the Scala Native support for paiges typelevel/paiges#338.

Once everything is working in CI then we should be good to go.

@larsrh
Copy link

larsrh commented Apr 6, 2021

Paiges 0.4.1 is out

@tgodzik
Copy link
Contributor

tgodzik commented Apr 6, 2021

@ekrich should I take a look at the PR and update paiges?

@ekrich
Copy link
Contributor Author

ekrich commented Apr 6, 2021

I was working on update upickle so I could use the latest that has all the cross projects.

I did see that paiges was updated.

@ekrich
Copy link
Contributor Author

ekrich commented Apr 6, 2021

@tgodzik
Copy link
Contributor

tgodzik commented Apr 7, 2021

@ekrich what do you think about #105 ?

@tgodzik
Copy link
Contributor

tgodzik commented Apr 7, 2021

@ekrich the other PR is merged and CI is fixed. We should be good to rebase this one 🎉

@ekrich
Copy link
Contributor Author

ekrich commented Apr 7, 2021

Sure, I will go ahead and rebase and then make the other changes. Note that @olafurpg said it was ok to drop 2.11 because paiges is 2.12+.

@ekrich
Copy link
Contributor Author

ekrich commented Apr 7, 2021

This works without tests but I cannot add them until the following project gets Native support.
https://github.com/alexarchambault/scalacheck-shapeless

I can do this but it will take a few days - hopefully. Added ticket: alexarchambault/scalacheck-shapeless#205

@tgodzik
Copy link
Contributor

tgodzik commented Apr 7, 2021

It's only CodecRoundtripSuite test from what I see, could we add is into a separate jvm folder? We wouldn't compile or run it for native.

@ekrich
Copy link
Contributor Author

ekrich commented Apr 7, 2021

I guess it is pretty much up to you. The tests being cross project would be nice. We could add a ticket to the scalacheck-shapeless and do that longer term on another PR - I don't know how much it is used so I don't know if it could be removed.

@ekrich ekrich changed the title WIP: Update versions to support Scala Native Update versions to support Scala Native Apr 7, 2021
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can follow up with a PR to separate the test tomorrow. I think we should be ok to merge and release? What do you think @olafurpg ? I fixed the release and it should work alright.

@olafurpg
Copy link
Member

olafurpg commented Apr 7, 2021

LGTM ship it!

@tgodzik tgodzik merged commit 6333827 into scalameta:master Apr 8, 2021
@ekrich ekrich deleted the topic/sconfig-native-040 branch April 8, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants