Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Scala Native #338

Merged
merged 1 commit into from Apr 5, 2021
Merged

Conversation

ekrich
Copy link
Contributor

@ekrich ekrich commented Apr 2, 2021

This adds support for Scala Native and Scala 3.0.0-RC2 for both JVM and JS.

There may be a few things that need to be touched up as I am not super knowledgeable about the build and CI process.

@johnynek
Copy link
Collaborator

johnynek commented Apr 2, 2021

Thanks for doing this!

It looks like the CI is still building for M2 and M3, I think we can probably ditch those and move to only doing RC2 IMO.

Also, the ci yaml I think is generated with githubWorkflowGenerate.

Let me know if running that sbt task fixes things.

Thanks again for the PR. I look forward to merging.

@ekrich
Copy link
Contributor Author

ekrich commented Apr 2, 2021

I think I figured it out. It looks like most repos were just moving from RC1 to RC2 with point releases.

We are needing this for scalameta/metaconfig so we can do a Scala Native scalafmt. I long time dream of ours.

Looks like a mima issue? scoverage?

@johnynek
Copy link
Collaborator

johnynek commented Apr 3, 2021

so, there are three things here:

  1. move to 2.12.13
  2. add 3.0.0-RC2
  3. add scala-native

Can we maybe do the minimal thing you need? Maybe just add scala-native, or add scala native and RC2? Can that side-step the issue here:

scoverage/sbt-scoverage#319

@ekrich
Copy link
Contributor Author

ekrich commented Apr 3, 2021

There is relentless upgrading going on. The easiest was to get the latest things but I may be able to back off some things. It is late here and I am pretty tired so I will try later this weekend. This is why the 2.12.13 is needed.
Error downloading org.scala-native:nscplugin_2.12.12:0.4.0

@johnynek
Copy link
Collaborator

johnynek commented Apr 3, 2021

scalacenter should fork and adopt scoverage.

@ekrich
Copy link
Contributor Author

ekrich commented Apr 3, 2021

Scala Steward is your friend too.

@ekrich
Copy link
Contributor Author

ekrich commented Apr 3, 2021

Now we are really hosed - tut-plugin.

@johnynek
Copy link
Collaborator

johnynek commented Apr 3, 2021

I guess we need to move to mdoc, added #339

@johnynek
Copy link
Collaborator

johnynek commented Apr 3, 2021

Now that #339 is closed by #340 can you merge master and see if we can keep the doc compiling?

@johnynek
Copy link
Collaborator

johnynek commented Apr 5, 2021

Okay...

I guess disabling coverage is worth it to support scala native since we rarely change the code these days anyway.

Thanks for the PR!

@ekrich
Copy link
Contributor Author

ekrich commented Apr 6, 2021

Thank-you. It seems people have been waiting on the coverage plugin for awhile and this will really help us downstream.

@ekrich ekrich deleted the topic/scala-native branch April 6, 2021 01:13
@larsrh
Copy link
Contributor

larsrh commented Apr 6, 2021

0.4.1 released with Scala Native support

@johnynek
Copy link
Collaborator

johnynek commented Apr 6, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants