Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation guide #7

Merged
merged 3 commits into from Nov 17, 2019

Conversation

ayoub-benali
Copy link
Collaborator

@ayoub-benali ayoub-benali commented Nov 16, 2019

pasting the repo URL in sublime is probably easier for end user and the package is always up to date.
Also closes #6

This a temporary solution until wbond/package_control_channel#7758 is merged.

pasting the repo URL in sublime is probably easier for end user
and the package is always up to date.

This a temporary solution until wbond/package_control_channel#7758
is merged.
README.md Outdated
2. In sublime's command palette type `Package Control: Add Repository`
3. At the bottom of the Sublime window, an input box will appear. Paste the URL of this repository (https://github.com/scalameta/metals-sublime)
4. In sublime's command palette type `Package Control: Install Packages` and select `metals-sublime`
5. Finally enable "metals-sublime" in your scala project via the command palette
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not clear to me what command to invoke here, is this correct?

Screenshot 2019-11-17 at 05 13 23

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the plugin behavior and the doc.
It should be enabled by default now on all scala projects so one step less for the user :)
I guess it is the same thing with the vscode plugin

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While trying this out, I hit on the following error

Screenshot 2019-11-17 at 05 16 00

Any idea what I may have done wrong? I just clean installed Sublime Text on a new computer

@ayoub-benali
Copy link
Collaborator Author

@predragnikolic it seems like the same error you had.
@olafurpg have you tried restarting sublime after installing the package ?

@predragnikolic
Copy link
Contributor

Yes, seems like the same error that happen to me.

I think, after I restarted Sublime for the second time, the popup went away and it started working.

Apparent there is a little bug when the the plugin is starting for the first time.

@ayoub-benali
Copy link
Collaborator Author

Thanks for the info, I will try to fix this issue in a separate PR.

@ayoub-benali ayoub-benali merged commit 51ebe4a into scalameta:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the plugin enabled by default
3 participants