Add LSP-metals plugin #7758
Add LSP-metals plugin #7758
Conversation
There was a problem hiding this comment.
Automated testing result: WARNING
Repo link: LSP-metals
Results help
Packages added:
- LSP-metals
Processing package "LSP-metals"
- WARNING: '.no-sublime-package' is defined. Please verify that it is *really* necessary
- WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.
There was a problem hiding this comment.
Automated testing result: WARNING
Repo link: LSP-metals
Results help
Packages added:
- LSP-metals
Processing package "LSP-metals"
- WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.
- WARNING: '.no-sublime-package' is defined. Please verify that it is *really* necessary
There was a problem hiding this comment.
Automated testing result: WARNING
Repo link: LSP-metals
Results help
Packages added:
- LSP-metals
Processing package "LSP-metals"
- WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.
- WARNING: '.no-sublime-package' is defined. Please verify that it is *really* necessary
|
|
There was a problem hiding this comment.
Automated testing result: WARNING
Repo link: LSP-metals
Results help
Packages added:
- LSP-metals
Processing package "LSP-metals"
- WARNING: '.no-sublime-package' is defined. Please verify that it is *really* necessary
pasting the repo URL in sublime is probably easier for end user and the package is always up to date. This a temporary solution until wbond/package_control_channel#7758 is merged.
* Update installation guide pasting the repo URL in sublime is probably easier for end user and the package is always up to date. This a temporary solution until wbond/package_control_channel#7758 is merged. * enable 'metals-sublime' by default * put back stable version
|
Perhaps we can use |
|
@rwols I am not sure to follow, are you talking about this line ? https://github.com/scalameta/metals-sublime/blob/master/plugin.py#L9 |
|
If it simplifies things, the package could download the |
|
@rwols how it currently stands, I believe this package to be mergeable, so I will go ahead and do that. It's by far not as problematic as the other LSP-* packages, because it ships a single cross-platform binary with it that is only 24KB. However, I will continue to request a review from you or another LSP developer/contributor to ensure what the package is doing aligns with LSP's interests. |
|
Thanks @FichteFoll |
Metals support for Sublime's LSP plugin.
It is similar to other language handlers in https://github.com/sublimelsp (see #7566, #7568, #7569 ) but for Metals. So far it provides:
More features are planned once the package published :)
cc @olafurpg