Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worksheets are not working on Windows #168

Closed
olafurpg opened this issue Dec 20, 2019 · 0 comments · Fixed by #169
Closed

Worksheets are not working on Windows #168

olafurpg opened this issue Dec 20, 2019 · 0 comments · Fixed by #169
Labels
bug Something isn't working

Comments

@olafurpg
Copy link
Member

Describe the bug

Decorations are not appearing for users on Windows. See https://gitter.im/scalameta/metals?at=5dfce536260751301cdf59ad

Additional context

The following diff supposedly fixes the issue

-        if (editor && params.uri === editor.document.uri.toString()) {
+        if (editor && Uri.parse(params.uri).toString() === editor.document.uri.toString()) {

Would somebody be interested in validating this fix and contributing a PR?
@olafurpg olafurpg added the bug Something isn't working label Dec 20, 2019
@tgodzik tgodzik mentioned this issue Jan 6, 2020
Merged
@gabro gabro closed this as completed in #169 Jan 6, 2020
@DhruvaSambrani DhruvaSambrani mentioned this issue Jul 8, 2020
Closed
kasiaMarek pushed a commit to kasiaMarek/metals-vscode that referenced this issue Mar 29, 2023
@mergify
Merge pull request scalameta#168 from scalameta/dependabot/npm_and_ya…
358b2c9 
…rn/types/node-14.6.0

Bump @types/node from 14.0.27 to 14.6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix worksheets on Windows tgodzik/metals-vscode
1 participant
@olafurpg