Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat JAVA_FLAGS the same as JAVA_OPTS #83

Closed
olafurpg opened this issue Feb 17, 2019 · 0 comments
Closed

Treat JAVA_FLAGS the same as JAVA_OPTS #83

olafurpg opened this issue Feb 17, 2019 · 0 comments

Comments

@olafurpg
Copy link
Member

Followup of scalameta/metals#529 We should respect JAVA_FLAGS the same way we do JAVA_OPTS

metals-vscode/src/getJavaOptions.ts

Line 22 in f8a49ba

const javaOpts = process.env.JAVA_OPTS;

olafurpg added a commit to olafurpg/metals-vscode that referenced this issue Apr 2, 2019
@olafurpg
Treat JAVA_FLAGS the same way as JAVA_OPTS, fixes scalameta#83.
5801f8a 
Previously, we ignored the JAVA_FLAGS environment variable, which is
frequently used to configure settings such as HTTP proxies. Now,
we respect JAVA_FLAGS so that Metals will work out of the box
for more users without custom configuration.
olafurpg added a commit that referenced this issue Apr 2, 2019
@olafurpg
Merge pull request #93 from olafurpg/java-flags
54a5713 
Treat JAVA_FLAGS the same way as JAVA_OPTS, fixes #83.
kasiaMarek pushed a commit to kasiaMarek/metals-vscode that referenced this issue Mar 29, 2023
@ckipp01
Merge pull request scalameta#83 from scalameta/dependabot/npm_and_yar…
6c27387 
…n/jest-25.3.0

Bump jest from 25.2.7 to 25.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olafurpg