Treat JAVA_FLAGS the same way as JAVA_OPTS, fixes #83. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we ignored the JAVA_FLAGS environment variable, which is frequently used to configure settings such as HTTP proxies. Now, we respect JAVA_FLAGS so that Metals will work out of the box for more users without custom configuration.
kasiaMarek
pushed a commit
to kasiaMarek/metals-vscode
that referenced
this pull request
Mar 29, 2023
…n/types/node-13.13.1 Bump @types/node from 13.13.0 to 13.13.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we ignored the JAVA_FLAGS environment variable, which is
frequently used to configure settings such as HTTP proxies. Now,
we respect JAVA_FLAGS so that Metals will work out of the box
for more users without custom configuration.