Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't start Metals due to conflicting GC settings #85

Closed
olafurpg opened this issue Feb 17, 2019 · 1 comment
Closed

Can't start Metals due to conflicting GC settings #85

olafurpg opened this issue Feb 17, 2019 · 1 comment

Comments

@olafurpg
Copy link
Member

Describe the bug

Metals crashes when starting in a workspace with .jvmopts that declares custom GC options

To Reproduce Steps to reproduce the behavior:

git clone monix/monix
code monix

Removing -XX:+UseConcMarkSweepGC from https://github.com/monix/monix/blob/baed192092b7c78624f0ea757d041909dda340e2/.jvmopts#L8 works around the issue.

Expected behavior

Metals should start like normal.

The bug lies here

!line.startsWith("-Xms") &&
!line.startsWith("-Xmx") &&
!line.startsWith("-Xss")
Instead of blacklisting memory options, we should consider whitelisting only HTTP proxy settings.

@olafurpg olafurpg changed the title Can't start Metals due to conflicting JVM options Can't start Metals due to conflicting GC settings Feb 17, 2019
@olafurpg
Copy link
Member Author

An alternative solution is to remove the default GC settings in

`-XX:+UseG1GC`,
`-XX:+UseStringDeduplication`
Those were added when Metals used 20-40x more memory than it does now.

@gabro gabro closed this as completed in 27393ae Apr 3, 2019
gabro added a commit that referenced this issue Apr 3, 2019
Remove default GC options, fixes #85.
kasiaMarek pushed a commit to kasiaMarek/metals-vscode that referenced this issue Mar 29, 2023
…n/types/node-fetch-2.5.6

Bump @types/node-fetch from 2.5.5 to 2.5.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant