Remove default GC options, fixes #85. #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Metals failed to start if the workspace .jvmopts file declared custom GC options because they conflicted with the default GC options we used. Now, we don't declare any default GC options so Metals can start in workspaces with custom GC and other VM options. The string deduplication option is not necessary because Metals uses little memory by default anyways. We started recommending this setting by default with the old Metals prototype that could sometimes consume multiple gigabytes of ram even on medium sized projects. If people want the old behavior, they can enable string deduplication in .jvmopts or in the "server properties" setting.
gabro
approved these changes
Apr 3, 2019
kasiaMarek
pushed a commit
to kasiaMarek/metals-vscode
that referenced
this pull request
Mar 29, 2023
…n/types/node-13.13.0 Bump @types/node from 13.11.1 to 13.13.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Metals failed to start if the workspace .jvmopts file
declared custom GC options because they conflicted with the default GC
options we used.
Now, we don't declare any default GC options so Metals can start in
workspaces with custom GC and other VM options.
The string deduplication option is not necessary because Metals uses
little memory by default anyways. We started recommending this setting
by default with the old Metals prototype that could sometimes consume
multiple gigabytes of ram even on medium sized projects. If people want
the old behavior, they can enable string deduplication in .jvmopts or in
the "server properties" setting.