Delay notification for slowTask for 2 seconds #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gourlaysama
force-pushed
the
feat/234-slow-task-progress
branch
2 times, most recently
from
1f0c8a1
to
0bcf281
Compare
tgodzik
approved these changes
Feb 17, 2021
tgodzik
requested changes
Feb 20, 2021
This waits 2 seconds before showing the full progress notification (assuming the task is still running by then). It avoids multiple notifications appearing and immediately leaving for short-lived tasks. Fixes scalameta#234
gourlaysama
force-pushed
the
feat/234-slow-task-progress
branch
from
0bcf281
to
933b977
Compare
tgodzik
added a commit
to tgodzik/metals-vscode
that referenced
this pull request
Feb 24, 2021
…progress Delay notification for slowTask for 2 seconds
kasiaMarek
pushed a commit
to kasiaMarek/metals-vscode
that referenced
this pull request
Mar 29, 2023
…rn/types/node-18.8.3 chore(deps-dev): bump @types/node from 18.8.2 to 18.8.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This waits 2 seconds before showing the full progress notification for slow tasks (assuming the task is still running by then).
It avoids multiple notifications like "Loading Presentation Compiler" appearing and immediately leaving because everything was ready and there was almost nothing to do.
Fixes #234